search

Centias / BankItems

Keep track of you inventory, bank, reagant bank, void storage and more across all your characters. Fork of the original BankItems on Curse/WowAce. Credit to XinHuan/Burstroc and anyone else who worked on the original.
26 stars 2 forks source link

Reagent backpack counted as "bank" #2

Closed madar2252 closed 1 year ago

madar2252 commented 1 year ago

If you have something in the new reagent backpack, the addon says it's in the bank.

GTSavvy commented 1 year ago

My fix so far has been to change this line:

https://github.com/Centias/BankItems/blob/1bd39b5e17180db282d270856c6d6a6c14a22c5e/BankItems.lua#L6467

to this

if bagNum >= BACKPACK_CONTAINER and bagNum <= NUM_TOTAL_EQUIPPED_BAG_SLOTS then

This part of the code doesn't seem to have been updated for Dragonflight to account for the new reagent bag. If it's acceptable, I can look into putting in a pull request for it...

EDIT: Also need to change here to fix it on characters you aren't currently logged in on:

https://github.com/Centias/BankItems/blob/1bd39b5e17180db282d270856c6d6a6c14a22c5e/BankItems.lua#L6373

Also here (this is about data exporting...?):

https://github.com/Centias/BankItems/blob/1bd39b5e17180db282d270856c6d6a6c14a22c5e/BankItems.lua#L5741

There are a few places where bag 5 is considered a 'bank' bag, but it's in functions named "UpgradeDataTo" so I'm not quite sure those should be changed...

GTSavvy commented 1 year ago

Added a Pull Request for this issue (#4)