CesiumGS / cesium

An open-source JavaScript library for world-class 3D globes and maps :earth_americas:
https://cesium.com/cesiumjs/
Apache License 2.0
13.03k stars 3.51k forks source link

Enable require pull request reviews before merging in GitHub #12197

Closed lukemckinstry closed 2 months ago

lukemckinstry commented 2 months ago

Feature

Under consideration is to enable the feature which is built in to GitHub to require an approval on a PR before it can be merged (see feature docs here). When enabled the approval status is shown in the "Checks" section at the bottom of a PR.

We discussed that the current team practice is to review and approval all PRs before merging, as described in the Cesium contributor guide, so this enabling this feature would just effectively formalize an existing process.

Some feature details to highlight:

ggetz commented 2 months ago

I've enabled this rule in the admin settings, and have allowed overrides for maintainers.

image

Please be on the lookout for how this is working out, and let us know here if there is any feedback.