Closed hotpocket closed 2 months ago
Thank you for the pull request, @hotpocket!
:white_check_mark: We can confirm we have a CLA on file for you.
@jjspace Could you please give this a review?
@jjspace I believe this is ready.
Sorry for any noise this caused in your notifications @hotpocket, we just updated prettier and I was trying to update your branch for you but turned out a little trickier than I thought but that was on my side.
This is finally good to go now
I am comforted to know that I am not the only one that still fights with git :slightly_smiling_face: (xkcd). Thanks @jjspace
Description
The
Rectangle.validate
function is only called in pragmas and has thus been an empty function call. Per issue #4921 it was suggested to make this private, presumably so that this behavior is explicit.Testing plan
All tests pass that were previously passing. There was one test that failed on my Ubuntu 22.04.05 OS. This is listed below:
This test was failing on unmodified version of main with the command
npm run test
. I assume this is "ok" with respect to this issue.Author checklist
CONTRIBUTORS.md
CHANGES.md
with a short summary of my change