CesiumGS / cesium

An open-source JavaScript library for world-class 3D globes and maps :earth_americas:
https://cesium.com/cesiumjs/
Apache License 2.0
13.03k stars 3.51k forks source link

per naming convention and #4921 this should make this `Rectangle.validate` private. #12212

Closed hotpocket closed 2 months ago

hotpocket commented 2 months ago

Description

The Rectangle.validate function is only called in pragmas and has thus been an empty function call. Per issue #4921 it was suggested to make this private, presumably so that this behavior is explicit.

Testing plan

All tests pass that were previously passing. There was one test that failed on my Ubuntu 22.04.05 OS. This is listed below:

TOTAL: 1 FAILED, 14300 SUCCESS

1) renders a point
     Scene/Vector3DTilePoints
     Expected to render [255,255,255,255], but actually rendered [254,254,254,255].
    at <Jasmine>
    at packages/engine/Specs/Scene/Vector3DTilePointsSpec.js:177:25 <- Build/Specs/SpecList.js:236887:24

This test was failing on unmodified version of main with the command npm run test. I assume this is "ok" with respect to this issue.

Author checklist

github-actions[bot] commented 2 months ago

Thank you for the pull request, @hotpocket!

:white_check_mark: We can confirm we have a CLA on file for you.

ggetz commented 2 months ago

@jjspace Could you please give this a review?

hotpocket commented 2 months ago

@jjspace I believe this is ready.

hotpocket commented 2 months ago

Sorry for any noise this caused in your notifications @hotpocket, we just updated prettier and I was trying to update your branch for you but turned out a little trickier than I thought but that was on my side.

This is finally good to go now

I am comforted to know that I am not the only one that still fights with git :slightly_smiling_face: (xkcd). Thanks @jjspace