Open dave-b-b opened 1 month ago
Thank you for the pull request, @dave-b-b!
:white_check_mark: We can confirm we have a CLA on file for you.
@jjspace Can you delete the other commits I had? I started over because I couldn't get the tests to pass. This one is much cleaner. If I can get help on the two tests that are failing, then I can move forward with this one.
@dave-b-b I'm a little confused on the state of this with https://github.com/CesiumGS/cesium/pull/12207 still open? should that PR be closed and only plan to merge this one?
All the tests look like they're passing on this branch, which ones are you having issues with?
I also still see a bunch of instances of defaultValue()
being used on this branch, are there commits missing? is this ready to review?
@jjspace Yes, I could not get the tests to pass on #12207, so I started over. You can delete that pull request because I redid everything here. I had two tests fail: ✗ renders a point ✗ renders pnts with point size style
They weren't passing on my machine. I'm almost done with this pull request. I'm trying to finish everything right now.
@jjspace I finished and submitted the final pull request, but I'm not sure whether I should rebase/merge.
A few of the tests are failing, so I must have messed something up. Can you help with this?
destroys resources after pixel datatype changes
Renderer/FramebufferManager
destroys resources after pixel format changes
Renderer/FramebufferManager
BalloonStyle: creates table from ExtendedData
DataSources/KmlDataSource
Parse Camera and LookAt on features
DataSources/KmlDataSource
recreates resources when HDR changes
Scene/GlobeTranslucencyFramebuffer
white
Scene/PostProcessStageCollection HDR tonemapping Reinhard
red
Scene/PostProcessStageCollection HDR tonemapping Reinhard
green
Scene/PostProcessStageCollection HDR tonemapping Reinhard
blue
Scene/PostProcessStageCollection HDR tonemapping Reinhard
white
Scene/PostProcessStageCollection HDR tonemapping Filmic
red
Scene/PostProcessStageCollection HDR tonemapping Filmic
green
Scene/PostProcessStageCollection HDR tonemapping Filmic
blue
Scene/PostProcessStageCollection HDR tonemapping Filmic
white
Scene/PostProcessStageCollection HDR tonemapping ACES
red
Scene/PostProcessStageCollection HDR tonemapping ACES
green
Scene/PostProcessStageCollection HDR tonemapping ACES
blue
Scene/PostProcessStageCollection HDR tonemapping ACES
white
Scene/PostProcessStageCollection HDR tonemapping PBR Neutral
grey
Scene/PostProcessStageCollection HDR tonemapping PBR Neutral
red
Scene/PostProcessStageCollection HDR tonemapping PBR Neutral
green
Scene/PostProcessStageCollection HDR tonemapping PBR Neutral
blue
Scene/PostProcessStageCollection HDR tonemapping PBR Neutral
renders with HDR when available
Scene/Scene
renders a point
Scene/Vector3DTilePoints
renders pnts with point size style
Scene/Model/Model3DTileContent pnts
changing specularEnvironmentMaps works
Scene/Model/Model imageBasedLighting
@jjspace Everything seems fine except two tests that I can't get to pass.
@jjspace Not sure why this test fails in the pipeline, but it passes when I run it on my computer....
@dave-b-b that statistics test failure is a known test failure we've been fighting in CI for a little bit. Don't worry about it https://github.com/CesiumGS/cesium/issues/11958
@jjspace I think this is done now. I add something to the change log under 2024-12-01
@jjspace Should I update the branch? I don't know what I should do. We already discussed the one test that is failing.
@jjspace I didn't realize that rebasing would bring in changes from other pull requests. The only way for me to undo this would be to redo the vast majority of the pull request. Can you help me figure this out?
Description
Issue number and link
Issue: 11674 https://github.com/CesiumGS/cesium/issues/11674
Testing plan
The following tests failed: ✗ renders a point ✗ renders pnts with point size style
Author checklist
CONTRIBUTORS.md
CHANGES.md
with a short summary of my change