Make `subscribeAndEvaluate()` for subscribing the knockout observable public

CesiumGS / cesium

An open-source JavaScript library for world-class 3D globes and maps :earth_americas:

https://cesium.com/cesiumjs/

Apache License 2.0

13.03k stars 3.51k forks source link

Make `subscribeAndEvaluate()` for subscribing the knockout observable public #12270

Closed lukemckinstry closed 3 weeks ago

lukemckinstry commented 4 weeks ago

What happened?

Cesium.subscribeAndEvaluate() does not show up in our docs page, (I believe because it is marked private ) . We point to it in our contributor guide. Should it be public and documented in the API docs?

Noticed in this forums conversation https://community.cesium.com/t/enable-globe-issue/36175/5

Reproduction steps

1. 2. 3. ...

Sandcastle example

No response

Environment

Browser: CesiumJS Version: Operating System:

ggetz commented 3 weeks ago

Thanks for prompting this discussion @lukemckinstry!

I'm not sure we want to stick with Knockout forever, given more modern solutions and well as some security concerns due to knockout. I would therefor hesitate to add public API coupled to this particular implementation.

Closing this as not planned, but let me know of further discussion is needed.