CesiumGS / cesium

An open-source JavaScript library for world-class 3D globes and maps :earth_americas:
https://cesium.com/cesiumjs/
Apache License 2.0
13.04k stars 3.51k forks source link

Remove deprecated createGooglePhotorealistic3DTileset key option in 1.126 #12328 #12330

Open monish-j opened 1 week ago

monish-j commented 1 week ago

Summary

This pull request addresses issue #12328 by removing the deprecated createGooglePhotorealistic3DTileset(key) function. The function has been replaced with the new format createGooglePhotorealistic3DTileset({key}).

Changes

Verification

Additional Notes

Please let me know if there are any additional documentation updates or other changes needed.

Thank you!

Issue number and link

Fixes #12328

Author checklist

[x] I have submitted a Contributor License Agreement

[x] I have added my name to CONTRIBUTORS.md

[x] I have updated CHANGES.md with a short summary of my change

[x] I have added or updated unit tests to ensure consistent code coverage

[x] I have updated the inline documentation, and included code examples where relevant

[x] I have performed a self-review of my code

github-actions[bot] commented 1 week ago

Thank you for the pull request, @monish-j! Welcome to the Cesium community!

In order for us to review your PR, please complete the following steps:

Review Pull Request Guidelines to make sure your PR gets accepted quickly.

monish-j commented 1 week ago

Hi @ggetz,

I have removed the deprecated createGooglePhotorealistic3DTileset(key) function and updated the code to use the new format createGooglePhotorealistic3DTileset({key}). The changes have been committed and pushed to the branch remove-deprecated-createGooglePhotorealistic3DTileset-key.

Could you please review the changes and let me know if there are any additional updates or documentation changes needed?

Thank you!