ChainSafe / lodestar

🌟 TypeScript Implementation of Ethereum Consensus
https://lodestar.chainsafe.io
Apache License 2.0
1.19k stars 300 forks source link

Gossip block signatures verification on main thread #5414

Open twoeths opened 1 year ago

twoeths commented 1 year ago

Describe the bug

Right now we verify gossip block proposer's signature on main thread but all other signatures on worker thread

Expected behavior

twoeths commented 1 year ago

with v1.8.0-rc.0 the time to verify execution payload is bigger so it may not be a priority atm

slot recvToVal recvToTransition recvToSigVer recvToVerifiedExecPayload
6314643 0.016 0.093 0.1219 0.2239
6314644 0.02099 0.12099 0.16699 0.31099
6314645 0.045 0.1319 0.158 0.305
6314646 0.0169 0.0959 0.1229 2.14
wemeetagain commented 1 month ago

@twoeths can this be closed?