search

ChameleonCloud / python-chi

Python client for the Chameleon testbed
Apache License 2.0
3 stars 4 forks source link

add support for manila - share service #32

Closed zhenz closed 2 years ago

zhenz commented 2 years ago

Excellent! I really love how neatly everything works in share.py :)

I found one API call we could avoid, but other than that it is perfect.

Also:

This change will require updates to the climeleon and jupyterhub images. Those images should be updated before this merges, because without manilaclient, python-chi will be unusable.

I don't fully understand why the changes in climeleon and jupyterhub-deploy are required, but I think it's good to have manila support in those places anyway. please see https://github.com/ChameleonCloud/climeleon/pull/14 and https://github.com/ChameleonCloud/jupyterhub-deploy/pull/12

super-cooper commented 2 years ago

I don't fully understand why the changes in climeleon and jupyterhub-deploy are required, but I think it's good to have manila support in those places anyway. please see ChameleonCloud/climeleon#14 and ChameleonCloud/jupyterhub-deploy#12

You're right, my brain was not working correctly. I forgot that python-chi's requirements.txt would pull them in.