ChargePoint / xcparse

Command line tool & Swift framework for parsing Xcode 11+ xcresult
MIT License
395 stars 47 forks source link

Fixes #16 keyNotFound ActionTestSummaryGroupCodingKeys subtests #17

Closed abotkin-cpi closed 5 years ago

abotkin-cpi commented 5 years ago

Change Description: These changes address the strict parsing issue with non-optional arrays #16 . If the JSON from xcresulttool did not return a key/value for the non-optional arrays, we would end up crashing with Illegal Instruction 4 keyNotFound as we were requiring to find that key. These changes make it so that for these non-optional arrays, we see if the key is present in the JSON & use it if so. If it isn't, we fill in with an empty array.

Test Plan/Testing Performed: Ran against SwiftiumTestingKit which saw this & saw correct parsing. Also ran against our internal Xcode 10 & Xcode 11 xcresults.