Closed OdNairy closed 4 years ago
@OdNairy Thanks for the detailed report! Would you be alright with this sample xcresult being included in our test suite?
I've got a possible fix & added your test for this in the branch origin/performance_metrics. Please feel free to take a look; I'll likely add a few more tests around that xcresult if you're fine with it's inclusion in the morning when I'm a little more awake.
Would you be alright with this sample xcresult being included in our test suite?
Yeah, no problem
This should now be addressed in 2.1.2. Thanks for the feedback @OdNairy!
Describe the bug Measurements has no elements in
ActionTestPerformanceMetricSummary
class.Desktop (please complete the following information):
2.1.0
. Also tested on latestmaster
branch5.2.4
(Xcode 11.6 [11E708])3.24
To Reproduce
Steps to reproduce the behavior: Run sample code over XCResult with performance metrics (sample.xcresult):
Expected behavior A clear and concise description of what you expected to happen.
Additional context During debugging I've noted that the following code uses
XCResultObject
class instead ofXCResultValueType
in this place: https://github.com/ChargePoint/xcparse/blob/7918fc648c79e86e01d6469e75b7098d8f77763c/Sources/XCParseCore/XCPResultDecoding.swift#L340-L356