Previously failed tests or negative test cases would freeze the test
job in GitHub Actions, due to them calling MessageBox, at which point
the job waits for a person to confirm the message. Even locally, the use
of TerminateProcess ended the testing.
With the use of ENABLE_COMMONLIBSSE_TESTING the behavior of a failure
changes to throwing an exception, which can be caught by negative test
cases, or results in a proper test failure.
This change also refactors the way in which inject/mock calls fail;
they still return a bool to indicate status but now log identically to
report_and_fail.
Previously failed tests or negative test cases would freeze the test job in GitHub Actions, due to them calling
MessageBox, at which point the job waits for a person to confirm the message. Even locally, the use ofTerminateProcessended the testing.With the use of
ENABLE_COMMONLIBSSE_TESTINGthe behavior of a failure changes to throwing an exception, which can be caught by negative test cases, or results in a proper test failure.This change also refactors the way in which
inject/mockcalls fail; they still return aboolto indicate status but now log identically toreport_and_fail.