search

CharrafiMed / global-search-modal

Enhances filamentphp's global search by transforming it into a modal for a better user experience
https://filamentphp.com/plugins/charrafimed-global-search-modal
30 stars 3 forks source link

Expand the url target #41

Closed NathanLochala closed 1 day ago

NathanLochala commented 2 days ago

First, @CharrafiMed I'm super impressed with your responsiveness. I had the issues yesterday and you pushed a fix same day. I didn't expect that, by any means, but am grateful for the quick fix. This suggestion doesn't require a quick fix. However, I think it could be very helpful.

Current, you can only click on the text of the search result to go to that item. However, it would be great if I could click anywhere on the search result and it take me to the item. For instance, in the below picture, the href is inside the <li> and doesn't include the area in the red circle:

image

However, it would be best if the whole section is clickable, like below:

image
CharrafiMed commented 2 days ago

Hey @NathanLochala!

Thank you! I'm really glad the quick fix worked for you.

Your suggestion about making the entire search result clickable is an excellent idea, and I can see how it would improve the user experience. I'll be looking into implementing this, as it could benefit the community.

For this feature, I plan to make it configurable like other features and have it controlled from the PHP plugin class. That way, developers can easily toggle this behavior based on their needs.

Also, I want to encourage you to keep the suggestions coming! Don’t hesitate to open new issues or feature requests—your input is valuable and helps make the project better for everyone. Even small ideas can lead to big improvements, so don’t be shy!

I'll keep this issue open and will provide updates as I explore the implementation. Thanks again for your continued contributions!

NathanLochala commented 2 days ago

Thank you, brother! I appreciate the feedback. I like the idea of making it configurable. I'll let you know if I think of anything else.