Chatterino / chatterino2

Chat client for https://twitch.tv
MIT License
2.06k stars 449 forks source link

fix: get rid of some more warnings #5672

Closed Nerixyz closed 3 weeks ago

Nerixyz commented 1 month ago

This mainly gets rid of -Wsign-compare warnings. These show up when compiling with clang-cl (I know we have them disabled usually). Since Qt 6.8 got a bit more vocal with deprecation warnings, I turned them off for now (only deprecations until 5.15 are enabled). This uses an undocumented QT_WARN_DEPRECATED_UP_TO. Once we switch to Qt 6, we can bump this.

Maybe we could enable -Wextra and -Wpedantic.