"show-.." commands via api_command() should not fail with discard_and_fail()

CheckPointSW / CheckPointAnsibleMgmtCollection

This Ansible collection provides control over a Check Point Management server using Check Point's web-services APIs.

https://galaxy.ansible.com/check_point/mgmt

Apache License 2.0

39 stars 30 forks source link

"show-.." commands via api_command() should not fail with discard_and_fail() #139

Open duanetoler opened 1 month ago

duanetoler commented 1 month ago

In module_utils/checkpoint.py, when apicommand() is called from a "show..." module and when error_code != 200, it should not fail with discard_and_fail(). The command is just a "show". This should fail like api_call_facts() without a discard.

chkp-edenbr commented 1 month ago

Hi @duanetoler , Will take this into consideration in the next version. Regards

duanetoler commented 4 weeks ago

Thanks! Would it be helpful if I made a PR for the patch I made?

chkp-edenbr commented 3 weeks ago

Hi @duanetoler , This is an open source collection, creating a PR would be great. Regards

duanetoler commented 1 day ago

PR #148 is ready