Treasury API and multi-currency support

[ShayanGsh]

Is your feature request related to a problem? Please describe.

ChestShop currently supports Vault and Reserve API, both of which are outdated and discontinued (my assumptions might be wrong, I'm judging based on their GitHub repos).

Describe the solution you'd like

Treasury is an alternative to Vault, supports multi-currency, and it's more optimized. Will ChestShop ever support that?

Describe alternatives you've considered

ChestShop has a much better UX compared to its alternatives, and we have been using it for long time for player-based shops. It's simple, clean and works well. But since we have admin shops that use another currency (that you buy with real money) we have had to use other shop plugins alongside ChestShop. I'm sure others would find multi-currency support useful as well.

Agreements

• [X] I have checked if there are already similar issues open.
• [X] I have checked that the latest build doesn't already implement the feature.

Additional context

No response

[Phoenix616]

Vault is still the defacto standard and while the project itself might not receive frequent updates that's kinda expected from a project that is basically feature complete and can't modify API anyways at it would break its whole ecosystem.

But that doesn't mean that I'm not open to including support for it in ChestShop. If someone writes a good PR I'm definitely willing to include it. I just most likely wont do that myself seeing as last time a new provider was added (Reserve) it basically lead to zero usage and Treasury itself seems to not have any activity since last year already (and I don't seem to be able to find which plugins are actually compatible with it 🤔)

Also I personally push for a different way of dealing with Vault's inactivity so investing too much time into alternative approaches seems counterproductive.

[ShayanGsh]

The feature I'm mostly looking for is multi-currency support, which Vault doesn't do, and since it's no longer developed, it probably won't ever support it.

There are a couple of newer or lesser-known economy plugins that do support Treasury, like Novaconomy or BetterEconomy. Still, It's true that it's not adopted as the new standard yet and it probably won't, there doesn't seem to be a big demand for multi-currency support.

I checked out Tresor, and great work man, keep it up. It's an excellent initiative for updating Vault. Is it a drop-in replacement for Vault? would it work that way? I might try adding multi-currency support to it at a later date if it wasn't added by then. I hope to see it more directly supported by economy plugins. I have only taken a quick glance at the code, but there seems to be an economy mechanic implemented into it?

[Phoenix616]

The feature I'm mostly looking for is multi-currency support, which Vault doesn't do, and since it's no longer developed, it probably won't ever support it.

Well multi-currency was already requested a long while ago (not sure where the issue for that is though, might've been on the DevBukkit forum) but as Vault didn't support it (and it's hard to indicate the currency on the sign) only per-world currency support was added. Adding proper API for that is one of the goals of Tresor.

Is it a drop-in replacement for Vault? would it work that way?

Yes, that's the goal. Of course plugins need to still use the newly added API.

I might try adding multi-currency support to it at a later date if it wasn't added by then. I hope to see it more directly supported by economy plugins. I have only taken a quick glance at the code, but there seems to be an economy mechanic implemented into it?

The issue for that is here:

• https://github.com/Minebench/Tresor/issues/16

[ShayanGsh]

In case of ChestShop, I don't know how it'd show the currency either yet, that's going to be a challenge (maybe the currency name would appear besides the stack size? since that number usually wont be higher than 3 digits).

Thank you sending the URL for the issue, I have bookmarked it for later use

One last question I've been wondering for a while, totally unrelated to this issue, after this one you can close this issue

Why ChestShop hasn't been updated on Bukkit and/or Spigot and why hasn't there been a stable release since 2022? Using a dev build feels like its going to be unstable

[Phoenix616]

Why ChestShop hasn't been updated on Bukkit and/or Spigot and why hasn't there been a stable release since 2022? Using a dev build feels like its going to be unstable

I simply haven't gotten around to doing it. As it's released on 5 different platforms and there is no good process of automatically pushing to them I simply did not see the worth and the dev build became the preferred way of running it as usually only actually working stuff will be merged to master. (And a release would be outdated as soon as a single bug was fixed in the dev builds anyways...)