Chew / JDA-Chewtils

Chew's fork of JDA-Applications/JDA-Utilities, with support for modern features such as Slash Commands, Context Menus, and more.
https://chew.pro/JDA-Chewtils
Apache License 2.0
73 stars 24 forks source link

Make SlashCommand#getHelp() return translated text when available. #90

Open Andre601 opened 4 months ago

Andre601 commented 4 months ago

Pull Request

Pull Request Checklist

Please follow the following steps before opening this PR.
PRs that do not complete the checklist will be subject to denial for missing information.

Pull Request Information

Check and fill in the blanks for all that apply:

Description

This overrides the getHelp() method to return a translated description using the default locale through getDescriptionLocalization().get(TranslateUtil.getDefaultLocale) This should allow a user to set the description within the localization files without needing to set the help text itself. Should there be no localized description for the default locale (Be null or empty) will it default to using this.help

This also adds getDefaultLocale() in the TranslateUtil to retrieve the default locale that was set.

I didn't add the same functionality to the name, as names in SlashCommands need to be alphanummeric when creating, which with this aproach would be problematic.

Given that this overrides a method for SlashCommand, should it automatically also be applied to Subcommands too.

Closes #89