search

Chi-teck / drupal-code-generator

A code generator for Drupal.
GNU General Public License v2.0
257 stars 46 forks source link

Shouldn't tests use "stark" theme now? #173

Open JPustkuchen opened 3 weeks ago

JPustkuchen commented 3 weeks ago

Just saw that drush gen test:webdriver uses protected $defaultTheme = 'claro';: https://github.com/Chi-teck/drupal-code-generator/blob/9641c755b893f3e6083a06c6f48fb92dfb50dae3/templates/Test/_webdriver/webdriver.twig#L19

Is that correct? Or isn't that the proposed base theme for webdriver tests? Perhaps I'm missing something?

I guess we should change this to the "stark" theme?

See:

I sadly couldn't find clear documentation or a change record pointing this out safe.

Chi-teck commented 3 weeks ago

I don't know if there is a "proposed" theme for tests. I personally prefer Claro as it has more convenient selectors in markup. However, given Drupal core and contrib modules mostly use Stark we might consider using Stark in DCG.