Remarks on figures and tables

[tomschenkjr]

• [x] A map of the beach locations would be helpful
• [x] Title missing for Figure 1
• [x] Table 2- would be improved if the authors also included a list of the attributes included in each of these models as well as what the ROC values were for these models. Typically and ROC >0.7 is considered a "good" performing model
• [x] **An additional table in a similar format as Table 2 showing the results from different models tried, along with the included attributes and corresponding ROC values would also help the reader understand the impact of the other environmental variables.

[nicklucius]

Will add a map and title for Figure 1. For Table 2, we can add some language in line 213 to explain what attributes were used.

For ROC values, calculate ROC values for the models and add to Table 2. This is similar to #61.

The request for an additional table is similar to #47 and #52.

[nicklucius]

Here is a first pass at a map.

[tomschenkjr]

Will you be able label with beach names? Everything else looks good.

_ Tom Schenk Jr. Chief Data Officer Department of Innovation and Technology City of Chicago (312) 744-2770 tom.schenk@cityofchicago.org | @ChicagoCDO data.cityofchicago.org | opengrid.io | digital.cityofchicago.org | chicago.github.io | dev.cityofchicago.org

---

From: Nick Lucius notifications@github.com Sent: Thursday, May 10, 2018 2:50:46 PM To: Chicago/predicting-e-coli-concentrations Cc: Tom Schenk; Author Subject: Re: [Chicago/predicting-e-coli-concentrations] Remarks on figures and tables (#54)

Here is a first pass at a map. [image]https://user-images.githubusercontent.com/16853555/39890780-7b8b8498-5461-11e8-8b50-fcd4bfe8d939.png

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHubhttps://github.com/Chicago/predicting-e-coli-concentrations/issues/54#issuecomment-388165489, or mute the threadhttps://github.com/notifications/unsubscribe-auth/ABkC0bIoLiaSNbN7HnJawBM7nvyF8ZDRks5txJoWgaJpZM4TV0y-.

---

This e-mail, and any attachments thereto, is intended only for use by the addressee(s) named herein and may contain legally privileged and/or confidential information. If you are not the intended recipient of this e-mail (or the person responsible for delivering this document to the intended recipient), you are hereby notified that any dissemination, distribution, printing or copying of this e-mail, and any attachment thereto, is strictly prohibited. If you have received this e-mail in error, please respond to the individual sending the message, and permanently delete the original and any copy of any e-mail and printout thereof.

[nicklucius]

@tomschenkjr I can think of a few different ways to do it. My first thought is to put labels right next to each beach, and for the North cluster of beaches, alternate left/right and/or space them out. Let me know if you think of other ideas to try out. I'll play around with it and repost.

[tomschenkjr]

Yeah, no particular idea, just whatever works for the display.

_ Tom Schenk Jr. Chief Data Officer Department of Innovation and Technology City of Chicago (312) 744-2770 tom.schenk@cityofchicago.org | @ChicagoCDO data.cityofchicago.org | opengrid.io | digital.cityofchicago.org | chicago.github.io | dev.cityofchicago.org

---

From: Nick Lucius notifications@github.com Sent: Friday, May 11, 2018 9:09:05 AM To: Chicago/predicting-e-coli-concentrations Cc: Tom Schenk; Mention Subject: Re: [Chicago/predicting-e-coli-concentrations] Remarks on figures and tables (#54)

@tomschenkjrhttps://github.com/tomschenkjr I can think of a few different ways to do it. My first thought is to put labels right next to each beach, and for the North cluster of beaches, alternate left/right and/or space them out. Let me know if you think of other ideas to try out. I'll play around with it and repost.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHubhttps://github.com/Chicago/predicting-e-coli-concentrations/issues/54#issuecomment-388374704, or mute the threadhttps://github.com/notifications/unsubscribe-auth/ABkC0YAhftMFTuemTWjSzhBuVWzUYIcyks5txZuAgaJpZM4TV0y-.

---

This e-mail, and any attachments thereto, is intended only for use by the addressee(s) named herein and may contain legally privileged and/or confidential information. If you are not the intended recipient of this e-mail (or the person responsible for delivering this document to the intended recipient), you are hereby notified that any dissemination, distribution, printing or copying of this e-mail, and any attachment thereto, is strictly prohibited. If you have received this e-mail in error, please respond to the individual sending the message, and permanently delete the original and any copy of any e-mail and printout thereof.

[nicklucius]

Beach labels added.

[tomschenkjr]

Awesome!

Tom Schenk Jr.

Chief Data Officer

Department of Innovation and Technology

City of Chicago

(312) 744-2770

tom.schenk@cityofchicago.org

data.cityofchicago.orghttps://data.cityofchicago.org | opengrid.iohttp://www.opengrid.io/ | digital.cityofchicago.orghttp://digital.cityofchicago.org | chicago.github.iohttps://chicago.github.io | dev.cityofchicago.orghttp://dev.cityofchicago.org

---

From: Nick Lucius notifications@github.com Sent: Friday, May 11, 2018 4:17:59 PM To: Chicago/predicting-e-coli-concentrations Cc: Tom Schenk; Mention Subject: Re: [Chicago/predicting-e-coli-concentrations] Remarks on figures and tables (#54)

Beach labels added. [image]https://user-images.githubusercontent.com/16853555/39947199-9fa54654-5536-11e8-85cd-12e509b397b2.png

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHubhttps://github.com/Chicago/predicting-e-coli-concentrations/issues/54#issuecomment-388488195, or mute the threadhttps://github.com/notifications/unsubscribe-auth/ABkC0UjUuJmqJ3EK8H_wqSSMMEduEvvwks5txgAHgaJpZM4TV0y-.

---

This e-mail, and any attachments thereto, is intended only for use by the addressee(s) named herein and may contain legally privileged and/or confidential information. If you are not the intended recipient of this e-mail (or the person responsible for delivering this document to the intended recipient), you are hereby notified that any dissemination, distribution, printing or copying of this e-mail, and any attachment thereto, is strictly prohibited. If you have received this e-mail in error, please respond to the individual sending the message, and permanently delete the original and any copy of any e-mail and printout thereof.

[tomschenkjr]

Did this code get committed? I see it's on issue54 branch, but no pull request yet?

[nicklucius]

You're right--It is committed to the issue54 branch but there's is no pull request--I'll add one now.

[tomschenkjr]

Looks like everything is done, so am closing.