Apollo Tracing changes status code to 500 on error

[oravecjakub]

Is there an existing issue for this?

• [X] I have searched the existing issues

Describe the bug

Hot Chocolate returns status code 500 Internal server error instead of 400 Bad request for invalid or too complex queries when Apollo Tracing feature is enabled Always or OnDemand.

Same behavior was observed when the query exceeded the complexity limit -- 500 with Apollo Tracing, 400 without it.

According to @michaelstaib, tracing should not change the status code https://github.com/ChilliCream/hotchocolate/issues/5116#issuecomment-1145813987

Steps to reproduce

1. Enable Apollo Tracing feature in On-demand mode (TracingPreference = TracingPreference.OnDemand)
2. Fire invalid request (e.g. request nonexistent field) without GraphQL-Tracing header
3. Observe 400 Bad request status ✔
4. Fire the same request but this time with the GraphQL-Tracing=1 header
5. Observe 500 Internal server error ❌

Relevant log output

No response

Additional Context?

No response

Product

Hot Chocolate

Version

12.11.0-preview.1

[michaelstaib]

I have tried it in our tests and I always get the correct status code 400. Can you create a small project that has this error?

[oravecjakub]

Thanks for looking into this. I've created an asp.net core project where the issue manifests. Nugets:

• HotChocolate @ 12.11.0-preview.1
• HotChocolate.AspNetCore @ 12.11.0-preview.1

Program.cs

using HotChocolate.Execution.Options;

var builder = WebApplication.CreateBuilder(args);

builder.Services.AddGraphQLServer()
    .AddApolloTracing(TracingPreference.OnDemand)
    .AddQueryType<QueryType>();

var app = builder.Build();

app.UseRouting();
app.UseEndpoints(endpoints =>
{
    endpoints.MapGraphQL("/graphql");
});

app.Run();

public class QueryType
{
    public string GetHello(string name) => $"Hello, {name}!";
}

Result without X-Apollo-Tracing header

Result with X-Apollo-Tracing header

Source code HC5118_Repro.zip

Hope this helps

[michaelstaib]

I have verified the error ... we will do a fix for 12.12.1

[michaelstaib]

This one is now fixed for version 12.12.1. I have issued the build and it should be available on NuGet in the next 30 min. I will still keep this issue open until this issue is also fixed for version 13.

[michaelstaib]

Thank you for the repro!