ChilliCream / graphql-platform

Welcome to the home of the Hot Chocolate GraphQL server for .NET, the Strawberry Shake GraphQL client for .NET and Banana Cake Pop the awesome Monaco based GraphQL IDE.
https://chillicream.com
MIT License
5.27k stars 748 forks source link

Fixed parsing issue in Utf8GraphQLRequestParser#ParseStringOrNull #7703

Closed glen-84 closed 3 weeks ago

glen-84 commented 3 weeks ago

Summary of the changes (Less than 80 chars)

Closes #7664


This fixes the main issue, but IMO ParseStringOrNull shouldn't return null for an empty string.

codecov[bot] commented 3 weeks ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 73.94%. Comparing base (02b1ca8) to head (0d843ff). Report is 28 commits behind head on main.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #7703 +/- ## ========================================== - Coverage 73.95% 73.94% -0.02% ========================================== Files 2917 2917 Lines 151116 151117 +1 Branches 17560 17560 ========================================== - Hits 111753 111737 -16 - Misses 33507 33525 +18 + Partials 5856 5855 -1 ``` | [Flag](https://app.codecov.io/gh/ChilliCream/graphql-platform/pull/7703/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=ChilliCream) | Coverage Δ | | |---|---|---| | [unittests](https://app.codecov.io/gh/ChilliCream/graphql-platform/pull/7703/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=ChilliCream) | `73.94% <ø> (-0.02%)` | :arrow_down: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=ChilliCream#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


🚨 Try these New Features: