ChilliCream / graphql-platform

Welcome to the home of the Hot Chocolate GraphQL server for .NET, the Strawberry Shake GraphQL client for .NET and Banana Cake Pop the awesome Monaco based GraphQL IDE.
https://chillicream.com
MIT License
5.27k stars 748 forks source link

Fix xml method description when dictionary args present #7765

Closed smbecker closed 2 days ago

smbecker commented 3 days ago

Fixes issue where XML method descriptions could not be retrieved when the method included a Dictionary as one of the parameters.

Closes #7764

CLAassistant commented 3 days ago

CLA assistant check
All committers have signed the CLA.

michaelstaib commented 3 days ago
image
smbecker commented 3 days ago
image

Should be fixed

codecov[bot] commented 2 days ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 74.33%. Comparing base (98c8879) to head (4becbd1). Report is 1 commits behind head on main.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #7765 +/- ## ========================================== - Coverage 74.33% 74.33% -0.01% ========================================== Files 2860 2860 Lines 149841 149842 +1 Branches 17411 17411 ========================================== - Hits 111389 111379 -10 - Misses 32655 32667 +12 + Partials 5797 5796 -1 ``` | [Flag](https://app.codecov.io/gh/ChilliCream/graphql-platform/pull/7765/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=ChilliCream) | Coverage Δ | | |---|---|---| | [unittests](https://app.codecov.io/gh/ChilliCream/graphql-platform/pull/7765/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=ChilliCream) | `74.33% <ø> (-0.01%)` | :arrow_down: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=ChilliCream#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.