search

Chitrank-Dixit / django-fcm

Django FCM provides firebase cloud messaging to android or ios support for django apps
https://django-fcm.readthedocs.io/en/latest/
MIT License
54 stars 28 forks source link

ImportError: cannot import name 'get_device_model' #21

Closed pratik-jambhulkar closed 7 years ago

pratik-jambhulkar commented 7 years ago

After adding the app to my django project, I got a import error:

File "/usr/local/lib/python3.5/dist-packages/fcm/forms.py", line 4, in from .models import get_device_model ImportError: cannot import name 'get_device_model'

It seems that you have moved the "get_device_model" function from models.py to utils.py and missed changing the import name in forms.py and admin.py

hibernatedguy commented 7 years ago

It seems it's a duplicate of #19. please import it from utils.py.

hibernatedguy commented 7 years ago

@pratikj009 I've already created a pull request for two bugs, wait for the update.

pratik-jambhulkar commented 7 years ago

Thanks for the update @ashish2py

arjuntheprogrammer commented 7 years ago

this issue is solved now..good work @ashish2py ; this issue must be closed now..