search

ChocoMeow / Vocard

Vocard is a simple music bot. It leads to a comfortable experience which is user-friendly, It supports Youtube, Soundcloud, Spotify, Twitch and more!
MIT License
111 stars 38 forks source link

RU language pack update and docker support added. #16

Closed Azarath7 closed 7 months ago

ChocoMeow commented 7 months ago

Thank you for the update. I appreciate your hard work and dedication. šŸ˜Š

For the docker file, we must add the port of ipc_server. Leave it to me

Azarath7 commented 7 months ago

Oh yeah, I totally forgot about that. I am not using dashboard feature yet, since I don't want to share my host's IP, so it was never configured and tested.

On Sat, Feb 3, 2024, 04:33 Choco @.***> wrote:

Thank you for the update. I appreciate your hard work and dedication. šŸ˜Š

For the docker file, we must add the port of ipc_server. Leave it to me

ā€” Reply to this email directly, view it on GitHub https://github.com/ChocoMeow/Vocard/pull/16#issuecomment-1925027530, or unsubscribe https://github.com/notifications/unsubscribe-auth/BFXU7ILWFMAJVBPZ4ZOXTV3YRWOZNAVCNFSM6AAAAABCTFPZ2WVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTSMRVGAZDONJTGA . You are receiving this because you authored the thread.Message ID: @.***>

Azarath7 commented 7 months ago

Also, in docker-compose there is a feature called "depends on". I have not discovered it fully yet. The reason I am telling you this, is that the docker-compose creates two separate containers for Lavalink and the bot. The bot depends on Lavalink and must wait for it to fully start, before trying to connect. So far I was fixing it by manually resrarting the bot, but I know, it is not the right approach. I am going to update it in a few days. I've been busy lately, so I don't have much time.

On Sat, Feb 3, 2024, 04:33 Choco @.***> wrote:

Thank you for the update. I appreciate your hard work and dedication. šŸ˜Š

For the docker file, we must add the port of ipc_server. Leave it to me

ā€” Reply to this email directly, view it on GitHub https://github.com/ChocoMeow/Vocard/pull/16#issuecomment-1925027530, or unsubscribe https://github.com/notifications/unsubscribe-auth/BFXU7ILWFMAJVBPZ4ZOXTV3YRWOZNAVCNFSM6AAAAABCTFPZ2WVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTSMRVGAZDONJTGA . You are receiving this because you authored the thread.Message ID: @.***>

ChocoMeow commented 7 months ago

Also, in docker-compose there is a feature called "depends on". I have not discovered it fully yet. The reason I am telling you this, is that the docker-compose creates two separate containers for Lavalink and the bot. The bot depends on Lavalink and must wait for it to fully start, before trying to connect. So far I was fixing it by manually resrarting the bot, but I know, it is not the right approach. I am going to update it in a few days. I've been busy lately, so I don't have much time. ā€¦ On Sat, Feb 3, 2024, 04:33 Choco @.> wrote: Thank you for the update. I appreciate your hard work and dedication. šŸ˜Š For the docker file, we must add the port of ipc_server. Leave it to me ā€” Reply to this email directly, view it on GitHub <#16 (comment)>, or unsubscribe https://github.com/notifications/unsubscribe-auth/BFXU7ILWFMAJVBPZ4ZOXTV3YRWOZNAVCNFSM6AAAAABCTFPZ2WVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTSMRVGAZDONJTGA . You are receiving this because you authored the thread.Message ID: @.>

Yes, I know, and Iā€™m testing all the Docker files right now. After I test them all, I will create a comment.