Chris-plus-alphanumericgibberish / dnethack

A variant of nethack 3.4.3
35 stars 13 forks source link

Feature/vs2015 merge #18

Closed kshanafelt closed 8 years ago

kshanafelt commented 8 years ago

Hi,

Your build of netHack got me interested in attempting to mod it. Currently I am just attempting to create a build that works for Visual Studio 2015. And change as little as possible in doing so.

This is a big pull request and I would not be offended if you denied it. I can create smaller pull requests, if you like. Or if you are simply not interested thats OK too.

The main reason for my pull request was because I have a question. I am rather new to C, and I suspect Visual Studio has less than stellar support for it.

The VS complier in dnethack-3.4.3/src/uhitm.c Doesn't like the sum[nattk] array create this way this a non constant size I had to change it get it to compile.

My question is, am I doing this right? Is there a better way? Could this be a failing in Visual Studio?