search

ChrisChinchilla / vscode-pandoc

Visual Studio Code extension lets you render markdown to pdf, word doc or html with pandoc
MIT License
25 stars 13 forks source link

Add docker.options support - fixed #32 #31

Closed raven42 closed 5 months ago

raven42 commented 10 months ago

Fixes: #32

When using this extension with a linux docker image, the file permissions are not always correct. So there is a need to specify the docker options to set the user-id and group-id.

This change adds the following configuration options:

ChrisChinchilla commented 6 months ago

@raven42 Sorry this PR fell in a hole when I wasn't getting GitHub notifications… Looking now!

ChrisChinchilla commented 6 months ago

@raven42 I don't quite have the setup to test this properly but I fixed up some TypeScript issues and built and ran and got the migration messages as I never used the extension with a container. Changes OK with you?

raven42 commented 6 months ago

@raven42 I don't quite have the setup to test this properly but I fixed up some TypeScript issues and built and ran and got the migration messages as I never used the extension with a container. Changes OK with you?

I'm not sure that would work as intended. It was using the same globalValue lookup for each if check. I pushed up another change to differentiate between the global config, workspace config, and folder config. Does that look correct?

ChrisChinchilla commented 5 months ago

@raven42 I don't really understand the statement. Sorry, this was to fix typescript type complaints, I don't think it changed the functionality, did it?

ChrisChinchilla commented 5 months ago

@raven42 Although it looks like whatever you added in the last commits kept the type fixes, so if you're happy with the combination of changes then I am happy!

sharifm-informatica commented 5 months ago

is it master or main?

ChrisChinchilla commented 5 months ago

@sharifm-informatica it should be main, I'm not sure when master crept back

sharifm-informatica commented 5 months ago

I suspected an issue. I cannot find that new code merged anywhere in this repo at the moment. Furthermore, I did not find it in release 4.7 either. Many thanks for the great work it changed many lives or at least workflows.

sharifm-informatica commented 5 months ago

I cannot find the code in this pull request anywhere. How can I help.

ChrisChinchilla commented 5 months ago

@raven42 @sharifm-informatica Oh dear I don't know what kind of mess I created there, re-merged and pushed a new release with the code.

raven42 commented 5 months ago

ah, had I opened the PR against the wrong branch? or had the branch changed after I created the PR? Sorry about that if so.

@ChrisChinchilla sorry I was out of touch for a while. Was travelling and not able to respond. My previous statement was with regard to where it was looking for the deprecated configuration. To provide a clear indication to the end user, I had intended to look for the old configuration in the global config, workspace config, and folder config and give a warning message to indicate where the old config was found since VS Code has a hierarchy of different config file locations. Your initial proposed changes was only looking at the global config, so my updated code was to build on that to also check the other config locations. Hope this makes more sense.

Thanks for helping get this merged in.

ChrisChinchilla commented 5 months ago

@raven42 Honestly I have no idea what happened, but we're all good now :) Thanks for the contribution!