search

ChrisViral / RealChute

Realistic parachutes for KSP
47 stars 38 forks source link

Adding a RealChute editor part filter #18

Closed ChrisViral closed 9 years ago

ChrisViral commented 9 years ago

Would probably be wise to add a custom filter that automatically targets RealChute parts. Pretty sure the code is done on my side, but I'd very much like to have some custom icons once more. So yeah, I'm looking at you @sumghai :p Whenever you have the time dude, no rush from me. I'll set it up to use stock icons for the time being.

sumghai commented 9 years ago

I'll need to figure out what dimensions / file format / etc the custom category filter icon(s) require.

FusTek and SDHI could benefit from this, too.

ChrisViral commented 9 years ago

The docs in the KSP folder say it needs to be 32x32 .png, and it must be on transparent background. The other good thing is that you can make a selected/not selected version and it'll shift between both. I'll add mine with the other stock icons (like engines, pods, and stuff), so if you can make the icon kinda alike them, that would be amazeballs.

sumghai commented 9 years ago

I'll get started this weekend, since I'm flying out later this afternoon and won't be back until Friday evening.

ChrisViral commented 9 years ago

No rush my friend, take all the time you need :) If you want a small plugin to do a similar thing for SDHI, hit me up!

ChrisViral commented 9 years ago

@sumghai , hm another thing I just noticed. If you have the time, mind also making a similar one for the filter by manufacturer filter tab? If it can be made in the same style as the others, that would be great too (grey when unselected, colours when selected)

sumghai commented 9 years ago

Yep, I'll look into this as well.

ChrisViral commented 9 years ago

Awesome, just do your thang, I'm not updating until you finish those :)

EDIT: also, for the manufacturer thing, the game defaults it to the RealChute logo it finds for the agency, and it's barely visible. I'd recommend either using the Wenkel logo or maybe contracting the RealChute logo to make it more visible/noticeable

sumghai commented 9 years ago

Okies, let's get started.

Just to clarify the requirements:

(*Apparently, RLA Stockalike used its agency flags for its manufacturer filter icons, and they aren't 32 x 32 px )

Are these correct? Did I miss anything?

I'm going to keep scouring the documentation for more info, since I'm not confident I understand the new system well enough to jump into making the icons right away (yet).

sumghai commented 9 years ago

Just spoke to some guys on kspmodders IRC:

sumghai commented 9 years ago

Manufacturer flag updated - the logo now has the enlarged parachute enlarged at the top, while the "REALCHUTE" and the ADRS text are at the bottom.

0080de7f5b7151c39cba0fcd760d9c54513cff06

I'll keep looking into the 32x32 RealChute Part Module filter icon(s).

ChrisViral commented 9 years ago

Yep, you got most of it right. Basically, the 32x32 icon is for the Filter by Module/Filter by Function icons.

As for the Filter by Manufacturer one, what it currently does is use the default RealChute agency logo. Turns out, agency logos are ALSO flags. This means that unfortunately, I had to remove the high resolution versions you made as they would not display correctly, and the Agencies config now refers to the images in the Flags folder. The Manufacturer filter automatically uses that flag, but there are indeed two problems:

What I suggest is that you create independant .png files which will end up in my PluginData folder which I will load as needed. You can make them flag sized, I'm pretty sure the system will automatically resize them, but it's mostly about making it more visible, and having a not selected state.

Thanks again for the hard work!

Edi: Looks good on the clarity side for the file you pushed to the repo :)

sumghai commented 9 years ago

So that would be four images going into your PluginData folder:

As requested, I'll redo the RealChute agency flag with the enlarged parachute enlarged at the top and "REALCHUTE" ADRS text at the bottom.

Let me know if this is correct :)

EDIT - Whoops, RealChute.png should stay in the Flags folder.

sumghai commented 9 years ago

Sorry again, just started up the game and realized that RealChute_unselected.png is not needed - I saw that FASA's agency flag is automatically darkened when not selected in the manufacturer filter.

ChrisViral commented 9 years ago

I'm not sure, when I tried on my side, the RealChute agency flag would not darken if not selected, it stayed blue. I guess we'll see, got to head to bed for now.

EDIT: ah also, ideally, the icon to be used for the Filter by Module and Filter by Function categories would be a parachute, not explicitely only RealChute, if it can be slightly coloured too (like the other Filter by Function icons), that would be fantastic. I'd want that icon to blend in with the others as if Parachutes is not an added category to the Filter by Function group :P

sumghai commented 9 years ago

I've pushed another commit for a full-sized RealChutes flag / manufacturer logo, and this is how things look like right now in my game:

rc_1

rc_2

The RC manufacturer logo does darken when not selected, but the effect isn't really noticeable because the Oxford Blue color used in the original logo is quite dark.

With regards to the Filter by Function & Filter by Module 32 x 32 px icons, there are two options:

My apologies for my tardiness lately >.<

ChrisViral commented 9 years ago

Alright, this seems good for me on the side of the manufacturer icon.

As for the parachutes Icon, I don't quite like the default stock icon. What I was thinking you could do is start off the icon you did for the Space Center toolbar, and give it a little shades and colour, I was thinking white/orange striped like the canopy textures. As I said, I don't want it to identify to RealChute only, just be a parachute icon which is better than the stock one :P

And no worries for the delay man, it's the holidays for everyone. I'm going on a cruise tomorrow so I mighyt be very inactive for a while

sumghai commented 9 years ago

As for the parachutes Icon, I don't quite like the default stock icon. What I was thinking you could do is start off the icon you did for the Space Center toolbar, and give it a little shades and colour, I was thinking white/orange striped like the canopy textures. As I said, I don't want it to identify to RealChute only, just be a parachute icon which is better than the stock one :P

Option 2 plus white/orange stripes? I think I can do that :)

ChrisViral commented 9 years ago

Yep that would do :) Don't forget to have it grayed out when inactive haha

sumghai commented 9 years ago

Just pushed another commit with the RealChuteModule filter icon(s) - I put them in the Icons directory, to keep with KSP 0.90.0 conventions for custom PartModule filter icons.

What do you reckon?

sumghai commented 9 years ago

Whoops, forgot to emboss the "selected" state icon.

BRB.

sumghai commented 9 years ago

Okies, updated with another commit.

Hope they look good in the editor.

ChrisViral commented 9 years ago

You are fabulous. I'll test this out tomorrow, and if this is all good I'll be closing this issue and pushing the update. Many thanks again! :)

ChrisViral commented 9 years ago

Works fantastic, thank you for your awesome work again sumghai! :)