search

CircleCI-Public / aws-ecr-orb

CircleCI orb for interacting with Amazon's Elastic Container Registry (ECR)
https://circleci.com/orbs/registry/orb/circleci/aws-ecr
MIT License
80 stars 142 forks source link

build to local and for one platform only and do not push image #346

Closed bob-rohan closed 2 months ago

bob-rohan commented 4 months ago

Orb version

9.1.0

What happened

Unable to 

  elif [ "${ORB_BOOL_PUSH_IMAGE}" -eq "0" ] && [ "${number_of_platforms}" -le 1 ];then
    set -- "$@" --load
  fi

Expected behavior

Able to

Per Docker examples, see scratch. https://docs.docker.com/build/building/multi-stage/

marboledacci commented 2 months ago

I don't understand what your issue is, could you explain better?

bob-rohan commented 2 months ago

I would like to build to local, for a single platform, without pushing. This is used to build an artifact which is extracted from the image, and subsequently uploaded to somewhere else. The above code block prohibits this behaviour.

marboledacci commented 2 months ago

I still don't understand, so you don't want the --load parameter added?

bob-rohan commented 2 months ago

correct --load is shorthand for --output=type=docker , which causes a conflict when attempting to output to local

marboledacci commented 2 months ago

Is there a reason why you need to use this orb for that? This doesn't seem to be related to ECR, and the docker-orb already lets you do it.

bob-rohan commented 2 months ago

yeah this is fine, thanks