search

CircleCI-Public / go-orb

https://circleci.com/orbs/registry/orb/circleci/go
MIT License
9 stars 37 forks source link

[semver:minor] Use built-in variables and common tools, translate HOSTTYPE #44

Closed mark-kubacki closed 2 years ago

mark-kubacki commented 4 years ago

HOSTTYPE (and OSTYPE, but that's superseded by OSD_FAMILY) is a built-in variable we use when available, which needs some translation to Go's idioms to cover more and popular architectures.

Consequently, to tackle the case of a cache getting restored from the wrong arch, check whether "go version" runs at all.

Further, the system might use 'go' (the binary) from a different directory than we expected prior to the change, rendering any updates and version checks ineffectual. Therefore it's less error-prone to delete it without any prior checks, and to establish a different order in PATH.

mark-kubacki commented 4 years ago

Tested for ARM on Scaleway.

gmemstr commented 3 years ago

@wmark Looks like a small conflict was introduced between this branch and master. Once that's resolved I feel comfortable merging this in.

KyleTryon commented 2 years ago

PR has been abandoned. Please feel free to re-open the PR with the requested changes.