Does this Orb require any changes to work with DockerHub auth?

CircleCI-Public / heroku-orb

Easily install and use the Heroku CLI with CircleCI to build, test, and deploy your applications to Heroku.

https://circleci.com/orbs/registry/orb/circleci/heroku

MIT License

6 stars 20 forks source link

Does this Orb require any changes to work with DockerHub auth? #19

Closed wheresrhys closed 4 years ago

wheresrhys commented 4 years ago

Describe Request:

When DockerHub starts rate limiting anonymous requests on Nov 1st, it looks like this Orb will be impacted, since there's no auth key in the docker config. It looks like a standard pattern is to expect DOCKERHUB_USERNAME/DOCKERHUB_PASSWORD environment variables (see example), will this (or something equivalent) be required for this Orb?

Examples:

https://discuss.circleci.com/t/updated-authenticate-with-docker-to-avoid-impact-of-nov-1st-rate-limits/37567/35

gmemstr commented 4 years ago

CircleCI has partnered with Docker Hub and will not be subject to rate limiting - you can read more here: https://support.circleci.com/hc/en-us/articles/360050623311-Docker-Hub-rate-limiting-FAQ