search

CircleCI-Public / path-filtering-orb

MIT License
24 stars 57 forks source link

Explode yaml before merge #94

Closed bentastic27 closed 2 months ago

bentastic27 commented 11 months ago

Fixes: https://github.com/CircleCI-Public/path-filtering-orb/issues/88

My change will resolve yaml aliases (exploding them?) before merging the yaml together. This solves the mentioned issue as well as another I faced where some aliases were rendered after the jobs/workflows they are used by in the resulting config file which causes errors.

pc-bob commented 2 months ago

Would be awesome to get this PR merged.

kelvintaywl commented 2 months ago

Thank you @bentastic27 and @pc-bob

I wanted to iterate that this looks to be an issue with the ireduce operator from yq. Ref: https://github.com/mikefarah/yq/issues/1738 where the user also solved their issue via using the explode operator.

Nevertheless, it is likely that CircleCI users use aliases and anchors in their config. So, using the path-filtering@1.0.0 orb can see the error explained by @bentastic27 and in #88 as well.

As a support engineer with CircleCI, I encountered this issue for another customer. Hence, I am reaching out to our engineers to see if we can have this merged 🙏