CiscoDevNet / ansible-nd

Cisco ND Ansible Collection
https://galaxy.ansible.com/cisco/nd
GNU General Public License v3.0
4 stars 14 forks source link

Addition of a new module: nd_backup and its test file #49

Closed shrsr closed 1 year ago

codecov-commenter commented 1 year ago

Codecov Report

Patch coverage: 42.72% and project coverage change: +0.52% :tada:

Comparison is base (f5fb674) 33.74% compared to head (4e5a5e2) 34.27%.

:exclamation: Current head 4e5a5e2 differs from pull request most recent head 7161f99. Consider uploading reports for the commit 7161f99 to get more accurate results

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #49 +/- ## ========================================== + Coverage 33.74% 34.27% +0.52% ========================================== Files 21 18 -3 Lines 1843 1730 -113 Branches 393 376 -17 ========================================== - Hits 622 593 -29 + Misses 1186 1086 -100 - Partials 35 51 +16 ``` | Flag | Coverage Δ | | |---|---|---| | integration | `34.27% <42.72%> (+0.71%)` | :arrow_up: | | sanity | `?` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=CiscoDevNet#carryforward-flags-in-the-pull-request-comment) to find out more. | [Files Changed](https://app.codecov.io/gh/CiscoDevNet/ansible-nd/pull/49?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=CiscoDevNet) | Coverage Δ | | |---|---|---| | [plugins/httpapi/nd.py](https://app.codecov.io/gh/CiscoDevNet/ansible-nd/pull/49?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=CiscoDevNet#diff-cGx1Z2lucy9odHRwYXBpL25kLnB5) | `36.22% <25.00%> (-1.88%)` | :arrow_down: | | [plugins/module\_utils/nd.py](https://app.codecov.io/gh/CiscoDevNet/ansible-nd/pull/49?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=CiscoDevNet#diff-cGx1Z2lucy9tb2R1bGVfdXRpbHMvbmQucHk=) | `22.80% <37.50%> (+0.68%)` | :arrow_up: | | [plugins/modules/nd\_backup.py](https://app.codecov.io/gh/CiscoDevNet/ansible-nd/pull/49?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=CiscoDevNet#diff-cGx1Z2lucy9tb2R1bGVzL25kX2JhY2t1cC5weQ==) | `42.30% <42.30%> (ø)` | | | [plugins/modules/nd\_cluster\_config\_route.py](https://app.codecov.io/gh/CiscoDevNet/ansible-nd/pull/49?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=CiscoDevNet#diff-cGx1Z2lucy9tb2R1bGVzL25kX2NsdXN0ZXJfY29uZmlnX3JvdXRlLnB5) | `45.65% <45.65%> (ø)` | | ... and [17 files with indirect coverage changes](https://app.codecov.io/gh/CiscoDevNet/ansible-nd/pull/49/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=CiscoDevNet)

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

akinross commented 1 year ago

assertion failing ofor nd_backup_restore please check and fix

shrsr commented 1 year ago

The ND was spun up again whose config. was empty. I modified the test case a bit to add some config before the backup and import.