search

City-of-Helsinki / django-helusers

Django app for City of Helsinki user infrastructure
BSD 2-Clause "Simplified" License
3 stars 14 forks source link

HP-2260 | Add new session serializer for Django 5.0 support #93

Closed charn closed 9 months ago

charn commented 9 months ago

This PR adds a new session serializer class, which is capable of serializing an expected datetime field in the session data. SOCIAL_AUTH_PIPELINE provided by this package needs to be able to handle a datetime field in the session data. Django 5.0 removes PickleSerializer which was deprecated earlier.

This PR also drops support for old (unsupported) Python and Django versions and adds Python 3.12 and Django 5.0 to tox tests.

danipran commented 9 months ago

Need to drop Python 3.7 from the test workflow: https://github.com/City-of-Helsinki/django-helusers/blob/master/.github/workflows/test.yml#L17

codecov[bot] commented 9 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 56.21%. Comparing base (e6d06a5) to head (e300ae2). Report is 1 commits behind head on master.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #93 +/- ## ========================================== + Coverage 55.58% 56.21% +0.62% ========================================== Files 30 31 +1 Lines 1047 1062 +15 ========================================== + Hits 582 597 +15 Misses 465 465 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.