search

CityOfZion / neo-sharp

Neo-sharp is a new core and node implementation of NEO focused on modular design, best coding practices and testability.
MIT License
35 stars 24 forks source link

Cleanup Blockchain, BlockPersist BlockHeaderPersist #475

Closed aboimpinto closed 6 years ago

aboimpinto commented 6 years ago

Cleanup BlockHeerPersister and BlockPersister. Code is cleaner and with less dependencies. Remove if statements Rename methods Remove event Inject BlockchainContext

codecov[bot] commented 6 years ago

Codecov Report

Merging #475 into development will increase coverage by 0.13%. The diff coverage is 18.18%.

Impacted file tree graph

@@               Coverage Diff               @@
##           development     #475      +/-   ##
===============================================
+ Coverage        53.44%   53.57%   +0.13%     
===============================================
  Files              301      301              
  Lines            12505    12460      -45     
===============================================
- Hits              6683     6676       -7     
+ Misses            5822     5784      -38
Impacted Files Coverage Δ
src/NeoSharp.Core/Blockchain/Blockchain.cs 32.35% <0%> (-6.68%) :arrow_down:
...Core/Blockchain/Processing/BlockHeaderPersister.cs 0% <0%> (ø) :arrow_up:
...rp.Core/Blockchain/Repositories/BlockRepository.cs 0% <0%> (ø) :arrow_up:
...e/Messaging/Handlers/BlockHeadersMessageHandler.cs 0% <0%> (ø) :arrow_up:
...Sharp.Core/Blockchain/Processing/BlockPersister.cs 0% <0%> (ø) :arrow_up:
...Sharp.Core/Blockchain/Processing/BlockProcessor.cs 100% <100%> (ø) :arrow_up:
...Blockchain/Processing/IssueTransactionPersister.cs 100% <100%> (ø) :arrow_up:
...ls/OperationManger/BlockHeaderOperationsManager.cs 93.75% <100%> (+0.64%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update a1a0dc2...166d9c1. Read the comment docs.