search

CityOfZion / neo-sharp

Neo-sharp is a new core and node implementation of NEO focused on modular design, best coding practices and testability.
MIT License
34 stars 24 forks source link

Add tests for BlockHeaderPersister #481

Closed aboimpinto closed 6 years ago

aboimpinto commented 6 years ago

During the development of the tests found that the validation of the block was creating an exponentiation number of tests. Extracting the validation to another class responsible only for the validation bring clarity and the validation it self can be tested alone without the "BlockHeaderPersister"

codecov[bot] commented 6 years ago

Codecov Report

Merging #481 into development will increase coverage by 0.55%. The diff coverage is 100%.

Impacted file tree graph

@@               Coverage Diff               @@
##           development     #481      +/-   ##
===============================================
+ Coverage        53.48%   54.03%   +0.55%     
===============================================
  Files              301      302       +1     
  Lines            12482    12488       +6     
===============================================
+ Hits              6676     6748      +72     
+ Misses            5806     5740      -66
Impacted Files Coverage Δ
...sing/BlockHeaderProcessing/BlockHeaderValidator.cs 100% <100%> (ø)
...sing/BlockHeaderProcessing/BlockHeaderPersister.cs 100% <100%> (ø)
src/NeoSharp.Core/DI/Modules/BlockchainModule.cs 100% <100%> (ø) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update c0bed71...2594182. Read the comment docs.