CityOfZion / neo-sharp

Neo-sharp is a new core and node implementation of NEO focused on modular design, best coding practices and testability.
MIT License
35 stars 24 forks source link

Make sync great again #490

Closed osmirnov closed 6 years ago

osmirnov commented 6 years ago

I've checked the sync by myself after the team worked on it. I've got it work but slow.

image

This is the result of running 1 hour debug session in VS. After I shuted down that experiment. Specs: Time elapsed: ~1 hour Blocks/Headers Synced: >200,000 Peers to sync: 4 initially, after 40 mins 1 disconnected

Observations

codecov[bot] commented 6 years ago

Codecov Report

Merging #490 into development will decrease coverage by 0.21%. The diff coverage is 6.25%.

Impacted file tree graph

@@               Coverage Diff               @@
##           development     #490      +/-   ##
===============================================
- Coverage        52.94%   52.72%   -0.22%     
===============================================
  Files              304      304              
  Lines            12760    12811      +51     
===============================================
- Hits              6756     6755       -1     
- Misses            6004     6056      +52
Impacted Files Coverage Δ
...Sharp.Persistence.RedisDB/RedisDbJsonRepository.cs 69.93% <0%> (-1.88%) :arrow_down:
src/NeoSharp.Core/Network/PeerMessageListener.cs 0% <0%> (ø) :arrow_up:
...rp.Core/Blockchain/Repositories/BlockRepository.cs 0% <0%> (ø) :arrow_up:
.../NeoSharp.Persistence.RocksDB/RocksDbRepository.cs 87.03% <0%> (-2.21%) :arrow_down:
...arp.Persistence.RedisDB/RedisDbBinaryRepository.cs 85.52% <0%> (-2.32%) :arrow_down:
...e/Messaging/Handlers/BlockHeadersMessageHandler.cs 0% <0%> (ø) :arrow_up:
...Sharp.Core/Blockchain/Processing/BlockProcessor.cs 100% <100%> (ø) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 51c369f...8b290be. Read the comment docs.