Closed justingaffney closed 5 years ago
if you can fix the unit tests, i will aprove it
:exclamation: No coverage uploaded for pull request base (
development@7293d33
). Click here to learn what that means. The diff coverage is26.92%
.
@@ Coverage Diff @@
## development #571 +/- ##
==============================================
Coverage ? 52.23%
==============================================
Files ? 357
Lines ? 16225
Branches ? 0
==============================================
Hits ? 8475
Misses ? 7750
Partials ? 0
Impacted Files | Coverage Δ | |
---|---|---|
...Sharp.Persistence.RedisDB/RedisDbJsonRepository.cs | 63.31% <0%> (ø) |
|
...NeoSharp.Persistence.RedisDB/RedisDbJsonContext.cs | 0% <0%> (ø) |
|
...chain/Processing/InvocationTransactionPersister.cs | 0% <0%> (ø) |
|
src/NeoSharp.Persistence.RedisDB/RedisDbContext.cs | 0% <0%> (ø) |
|
...arp.Persistence.RedisDB/RedisDbBinaryRepository.cs | 77.97% <0%> (ø) |
|
...e/Blockchain/Repositories/TransactionRepository.cs | 24.17% <0%> (ø) |
|
.../NeoSharp.Persistence.RocksDB/RocksDbRepository.cs | 78.88% <0%> (ø) |
|
...c/NeoSharp.BinarySerialization/BinarySerializer.cs | 97.08% <100%> (ø) |
|
src/NeoSharp.Core/Models/Transaction.cs | 100% <100%> (ø) |
|
src/NeoSharp.Core/VM/StateReader.cs | 29.25% <83.33%> (ø) |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update 7293d33...71d0f80. Read the comment docs.
I have made the requested changes to fix the unit test, could you please review it again?
Issue #389