search

CityRiverSpaces / CRiSp

CRiSp (City River Spaces) provides tools to automate the morphological delineation of riverside urban areas.
https://cityriverspaces.github.io/CRiSp/
Apache License 2.0
0 stars 0 forks source link

Test coverage minimum 75% #11

Open cforgaci opened 5 months ago

cforgaci commented 5 months ago

Submission for peer review in rOpenSci requires 75% test coverage. I suggest we make tests for current functions until we meet this target and make sure to write tests while developing functions to maintain that coverage.

fnattino commented 2 weeks ago

27 and #39 definitely increase test coverage, but I am not sure whether the target coverage will be reached, thus reopening this. The fact that tests on osmdata cannot be run as part of the CI probably affects us with a lower-than-actual coverage. If the resulting coverage turns out to look too low we should look into using mocks to replace parts of the osmdata module.