search

Civcraft / Humbug

Do not open issues here; open them on the maintained fork @ DevotedMC
https://github.com/DevotedMC/Humbug
BSD 3-Clause "New" or "Revised" License
3 stars 11 forks source link

Possible root of 4-heart bug. #71

Open kksym opened 8 years ago

kksym commented 8 years ago

https://github.com/Civcraft/Humbug/blob/master/src/main/java/com/untamedears/humbug/Humbug.java#L1761

ignoreCancelled = true

Possible cause of the 4-heart bug? If under a certain condition the event is cancelled (doesn't appear to ever be cancelled in Humbug however) and the event is uncancelled after the strength reversions were supposed to apply, presumably the damage would be vanilla. I have no idea which plugins may fiddle with EntityDamageByEntity events (possibly NoCheatPlus/CombatTag/private server-side anticheat thingy), but unless I'm missing something very obvious, it seems plausible.

ProgrammerDan commented 8 years ago

Hmm, so as LOWEST priority this event would only potentially be superseded by another plugin having the same event trapped at also LOWEST priority.

More likely is that another plugin is overriding the changes Humbug is making here then that Cancelled is involved (as when this is called, again, it is unlikely any other handler has been called, so the event will never have been cancelled).

This due to Bukkit running events in reverse priority -- LOWEST is first, MONITOR is last.

Diet-Cola commented 8 years ago

Seen here at 52:52

Go from 7 hearts down to 3 hearts on one hit.

ProgrammerDan commented 8 years ago

Wish I knew exact date and time on that (in server timezone) so I could pull the 2.0 logs and see if anything pops up on console (exception, etc).

Diet-Cola commented 8 years ago

‎19 ‎September ‎2015, ‏‎00:45:29 GMT was the time the video was recorded.

Given that the video would of finished, the event happened 50 minutes from the end meaning at roughly 18 September 2015 11:55:00 GMT is a rough idea.

ProgrammerDan commented 8 years ago

I'll see what I can find / have access to.