Changing varchar(36) to char(36) for UUID fields + minor optimization

Civcraft / PrisonPearl

Minecraft plugin for civcraft which allows players to imprison other players inside ender pearls

BSD 3-Clause "New" or "Revised" License

4 stars 16 forks source link

Changing varchar(36) to char(36) for UUID fields + minor optimization #93

Closed Sander-Kastelein closed 8 years ago

Sander-Kastelein commented 8 years ago

Since UUID.getString() will always return a 36 character long string, it's more efficient to use a CHAR(36) column than a VARCHAR(36). Also loading the Location objects once instead of 4 times should make it a little bit faster, (and make it a bit more readable).

Greets,

CivcraftBot commented 8 years ago

Can one of the admins verify this patch? Type 'ok to test' to test.

ProgrammerDan commented 8 years ago

This is great. We've got a partial re-write in the wings right now; I'll be sure that these changes show up in the final version. You can check that version out here: https://github.com/Civcraft/PrisonPearl/tree/3.0

Maxopoly commented 8 years ago

Closing, because the plugin was completly rewritten in the meantime