[BUG] Wrong leader finishes naming ceremony

[deadpaan7391]

Type: Code (I think)

Describe the bug When reading the naming ceremony for a new leader, the preceding leader was not the one to finish the ceremony. In my screenshots, you'll see that Elkstar was the leader before Flashstar, but Elkstar was the one to give Firestar their final life.

Grade: (only select one) Unimportant

Reproduce Promote a new leader while having multiple previous leaders (I have 9 dead leaders preceding Firestar, idk if the large number has an affect)

Commit # or Game Version Number: 0.11.2

Additional context Add any other context about the problem here.

Screenshots

[rustykitty]

Who began the naming ceremony? You only provided a screenshot of the end.

[scribblecrumb]

This is not a bug. The last life can be given by any of the following:

• A leader that the new leader has existing positive relationship values with
• The oldest dead leader
• The leader preceding the new leader

I would presume that in this case, Firestar had known Elkstar when they were alive.

[deadpaan7391]

Sorry it took me so long to get back. Elkstar died before Firestar was born, they did not know each other and have no existing relationship. Elkstar is also not the oldest existing dead leader. I don't know if this changes anything, but I've provided more screenshots just in case, including the full naming ceremony.

[scribblecrumb]

Hm alright, yeah it looks like something must be wrong then

[j-gynn]

/assign-me

[github-actions[bot]]

👋 Hey @j-gynn, thanks for your interest in this issue! 🎉

⚠ Note that this issue will become unassigned if it isn't closed within 7 days.

🔧 A maintainer can also add the 📌 Pinned label to prevent it from being unassigned automatically.

[j-gynn]

It's quite hard to confirm whether this will fix this bug since I can't recreate it, but I have suspicions that it's because somehow the starclan_cats list has ended up out of order relative to moons since death. I'll push that as a PR and hopefully that'll fix it, but unless I can have the save file or somehow recreate it, it's going to be tricky to confirm.