search

Clarenceeey / pe

0 stars 0 forks source link

Chaining find command #5

Open Clarenceeey opened 2 weeks ago

Clarenceeey commented 2 weeks ago

Steps to reproduce:

  1. Enter find david
  2. Enter find alex

After the first command, only entries that have "david" in their name will appear

image.png

However, after typing the second command, I expected it to filter all the "alex" from this list, but instead it finds all "alex" in the full list

image.png

Might hinder a user when he searches for a common username (i.e. "tan"), then out of all those whose surnames are "tan", he wants to search for one whose name contains "alex", but instead he is returned a list of all "alex", even those whose surname is not "tan"

soc-pe-bot commented 1 week ago

Team's Response

The behaviour is as expected, where the find command obtains details from the entire list of patients instead from the filtered view of patients. This was stated in the User Guide as follows:

Finds patients whose names contain any of the given keywords.

If there is a need to find both david and/or alex in their name, the user should type find david alex.

We lowered the severity, since we already specified the functionality in the UG. Furthermore, it is unlikely for the user to find twice, given that they should just search in the same command.

Items for the Tester to Verify

:question: Issue response

Team chose [response.Rejected]

Reason for disagreement: User guide says Finds patients whose names contain any of the given keywords., but did not say whether it will find from the entire list or the filtered list.

Furthermore, this is a valid use case because

  1. It feels more natural to search from the filtered list instead of the whole list
  2. A user could want to narrow down the search before searching for the second keyword
## :question: Issue severity Team chose [`severity.Low`] Originally [`severity.Medium`] - [ ] I disagree **Reason for disagreement:** [replace this with your explanation]