Clarenceeey / pe

0 stars 0 forks source link

Unclear restrictions on delete command #7

Open Clarenceeey opened 2 weeks ago

Clarenceeey commented 2 weeks ago

For find command, specifing find alex returns alex

image.png

However, for delete command, specifying delete n/alex does not delete alex

image.png

User guide does not mention how strings are processed for delete command, and inconsistent parsing of strings can cause users to get confused

image.png

soc-pe-bot commented 1 week ago

Team's Response

There is a misunderstanding in the find and delete command. It is stated in the find command that it is used such that "Persons matching at least one keyword will be returned", meaning that the full name is not required for the find command. (only the KEYWORD is required) However, for the delete command, matching the exact NAME is required, as mentioned in the User Guide.

Items for the Tester to Verify

:question: Issue response

Team chose [response.Rejected]

Reason for disagreement: Although I don't think this issue is a medium severity upon revision (maybe low), it should still have been explicitly stated in the user guide that the full name has to be provided instead of saying that NAME has to be matched.

Also, in the examples given, perhaps it would have been better to give examples that used full names instead of just a first name (i.e. use the example delete n/John Tan Xiao Ming instead of the example delete n/john to make it clearer that the whole name has to be matched)