search

ClayAmore / ER-Save-Editor

Elden Ring Save Editor. Compatible with PC and Playstation saves.
Apache License 2.0
313 stars 80 forks source link

Fix save wizard file identification check #57

Open klarkyson opened 4 months ago

klarkyson commented 4 months ago

As of the DLC release the regulation contents can no longer be used to compare to a checksum for identification.

This PR opts instead to attempt to decrypt and decompress the regulation contents such that if it succeeds the program assumes the file is the save wizard format. This is a bit slower than the checksum, but at least it's consistent!

llolnyj commented 4 months ago

The new hotfix is not working. It instantly crashes when I open SL2 file with it:(

noamb14 commented 4 months ago

it says that the save data is corrupted when I got the save file from the ps4 back to the pc

klarkyson commented 4 months ago

Did either of you build from my branch?

I'm not having these issues. If you did build from my branch please post your saves and what game version you're using.

gaseet commented 4 months ago

Hello klarkyson, I just built from your branch, and while I can open my save, the scadutree blessing option isn't there, and all dlc items only have ids and no names, is this intended?

noamb14 commented 4 months ago

Did either of you build from my branch?

I'm not having these issues. If you did build from my branch please post your saves and what game version you're using.

Hi. It actually did work. I didnt press the import character buttin and thats why it didnt work. If you start a ng+ it will still work tho right?

babbatem commented 4 months ago

thanks, @klarkyson. Does this include items from the DLC?

e.g. from this PR -- https://github.com/ClayAmore/ER-Save-Editor/pull/49#issue-2376054428