Add CLI option to disable colorama #118

Closed dougthor42 closed 8 years ago

This PR adds a -W or --nowindows command line argument that, when present, disables windows support via Colorama.

This is useful for some CI cases, such as GitLab. See #117.

I'm not super happy with --nowindows and no_windows, but I couldn't come up with anything better.
- disablewindowssupport is much more descriptive, but too long and hard to read without CamelCase

You've got some interesting AppVeyor output weirdness and a test failure to deal with. ;-)

Yup, just saw those. Poop.

It looks like Appveyor is printing some of the ANSI codes. I can't seem to recreate it on my end - when I run tests everything looks just fine.

(Working dir is the green project root (with README.md, etc. in it))

> pip uninstall green -y
> python setup.py sdist bist_wheel
> pip install dist\green-2.3.0-py3-none-any.whl
> green green -s 1 -vv -W      # correctly does *not* color things and *does* have ANSI codes displayed
> green green -s 1 -vv         # correctly colors things.
> python -m green.cmdline -s 1 -vvv -t green   # the same command that Appveyor runs

None of the 3 outputs display what Appveyor is showing. I'm using -s 1 because I'll intermittently get tests that hang on multiprocess stuff.

Also, the Travis Builds are failing but it looks unrelated to this PR.

I took a look at the Appveyor build history. The odd "80" and "24" printed lines started between builds 273 (commit 51a709c77c655635d2a3e957f1b4f15fb773bd45) and 274 (commit 366f48ea945af5ab931c8071762cf1b5081ba118).

So I'm going to say "it wasn't me!" and breathe a sigh of relief :laughing:.

Unless you have any other comments on it, I'll stop development and you can merge at your leisure.

Okay, I'll review it soon as I can. No promises on the timeline, I'm in crunch time for my real job. ;-)

CleanCut / green

Add CLI option to disable colorama #118