Un-unicode output for Windows CMD

CleanCut / green

Green is a clean, colorful, fast python test runner.

MIT License

791 stars 75 forks source link

Un-unicode output for Windows CMD #120

Closed MinchinWeb closed 8 years ago

MinchinWeb commented 8 years ago

Fixes #119

coveralls commented 8 years ago

Coverage decreased (-0.1%) to 99.894% when pulling c95ecc888b3cf4ac7fa5e6013921ad0cfc7b7a3c on MinchinWeb:fix-119 into 73872d97a94b5d219cbebbb72c2be52dcbac7a4f on CleanCut:master.

coveralls commented 8 years ago

Coverage remained the same at 100.0% when pulling b985bc50906b06dc92f3c8426d4c22192ebe7c5f on MinchinWeb:fix-119 into 73872d97a94b5d219cbebbb72c2be52dcbac7a4f on CleanCut:master.

jayvdb commented 8 years ago

All of these "on_appveyor" conditions look like handling only the simple case of Appveyor, and dont really test using green on Windows because there is special logic for Appveyor only.

e.g. I expect that green > green.log on Windows will fail, because it is more like an Appveyor environment (i.e. no stdin, which Python uses to determine console encoding).

This is just a general comment, as I realise that this changeset isnt introducing "on_appveyor", but it is making it more "normal" by exposing it as an attribute.

coveralls commented 8 years ago

Coverage remained the same at 100.0% when pulling 7f76c846b873d3062e649b64b61cd2af4b9b42f0 on MinchinWeb:fix-119 into 73872d97a94b5d219cbebbb72c2be52dcbac7a4f on CleanCut:master.

coveralls commented 8 years ago

Coverage remained the same at 100.0% when pulling a9ebf9132a642ff20e4a0b27556824c7ef178bf1 on MinchinWeb:fix-119 into 73872d97a94b5d219cbebbb72c2be52dcbac7a4f on CleanCut:master.

MinchinWeb commented 8 years ago

@jayvdb I've reworked the 'flags' inside the module a little to try and make things more explicit.

The test failed on Travis because coverage timed out.

The test failed on Appvoyor on a test where colorama is supposed to strip ANSI codes. But the issue is something gets fed a str but is expecting a unicode. Is this an issue with Python 2.7? With colorama? With unidecode? I'm not sure. Part of the reason I moved to Python 3 was to avoid the str/unicode mess... Suggestions??

In any case, the tests do pass on my local machine.

coveralls commented 8 years ago

Coverage remained the same at 100.0% when pulling 9aa6f366d68fbb26ca227a9366b539b57eacad68 on MinchinWeb:fix-119 into 73872d97a94b5d219cbebbb72c2be52dcbac7a4f on CleanCut:master.

MinchinWeb commented 8 years ago

@CleanCut: I've made the changes you suggested

CleanCut commented 8 years ago

Included in the 2.4.2 release. Which was just released.