Closed MinchinWeb closed 8 years ago
All of these "on_appveyor" conditions look like handling only the simple case of Appveyor, and dont really test using green on Windows because there is special logic for Appveyor only.
e.g. I expect that green > green.log
on Windows will fail, because it is more like an Appveyor environment (i.e. no stdin, which Python uses to determine console encoding).
This is just a general comment, as I realise that this changeset isnt introducing "on_appveyor", but it is making it more "normal" by exposing it as an attribute.
@jayvdb I've reworked the 'flags' inside the module a little to try and make things more explicit.
The test failed on Travis because coverage
timed out.
The test failed on Appvoyor on a test where colorama is supposed to strip ANSI codes. But the issue is something gets fed a str
but is expecting a unicode
. Is this an issue with Python 2.7? With colorama
? With unidecode
? I'm not sure. Part of the reason I moved to Python 3 was to avoid the str/unicode mess... Suggestions??
In any case, the tests do pass on my local machine.
@CleanCut: I've made the changes you suggested
Included in the 2.4.2 release. Which was just released.
Fixes #119