search

CleanCut / green

Green is a clean, colorful, fast python test runner.
MIT License
791 stars 75 forks source link

Remove duplicate attempt to put test in queue #126

Closed skeggse closed 8 years ago

skeggse commented 8 years ago

Added in efb54c0. The test is already put into the queue in the start_callback, which filters out this second attempt with the set, but shouldn't need to.

coveralls commented 8 years ago

Coverage Status

Coverage remained the same at 100.0% when pulling 6d488f7868b24fa1fe3882c61bd1a0bc25548007 on skeggse:patch-2 into 7f4655af690fede737b1cb0dd1cda0bc9f794e60 on CleanCut:master.

skeggse commented 8 years ago

Huh. Not sure how this change would make the --disable-windows test stop working

CleanCut commented 8 years ago

Ah, you found it! That's why I added the filtering, because I couldn't find this case.

Quite frankly, I hate the method of communication being used. I simply couldn't find a better way without introducing extra module dependencies. (I was tempted to pull in pyzmq and use message-passing, which would be soooo much cleaner architecturally).

CleanCut commented 8 years ago

Oh, and you didn't break the build. pypy has race conditions on Ubuntu on TravisCI. Dunno why. When that connection error occurs, I just re-run the build repeatedly until it passes. Not the best solution, but since I have never been able to reproduce the race condition locally, I dunno what to do to fix it.

CleanCut commented 8 years ago

Included in 2.5.1 (just released).

skeggse commented 8 years ago

:+1: