Closed skeggse closed 8 years ago
Huh. Not sure how this change would make the --disable-windows
test stop working
Ah, you found it! That's why I added the filtering, because I couldn't find this case.
Quite frankly, I hate the method of communication being used. I simply couldn't find a better way without introducing extra module dependencies. (I was tempted to pull in pyzmq and use message-passing, which would be soooo much cleaner architecturally).
Oh, and you didn't break the build. pypy has race conditions on Ubuntu on TravisCI. Dunno why. When that connection error occurs, I just re-run the build repeatedly until it passes. Not the best solution, but since I have never been able to reproduce the race condition locally, I dunno what to do to fix it.
Included in 2.5.1 (just released).
:+1:
Added in efb54c0. The test is already put into the queue in the
start_callback
, which filters out this second attempt with the set, but shouldn't need to.