CleanroomMC / MixinBooter

Allows any mixins that work on mods to work effortlessly. With a single class and an annotation. On 1.12.2.
GNU Lesser General Public License v2.1
49 stars 17 forks source link

8.0 crash with `Redstone Arsenal` (actually `Better Hurt Timer`) #31

Open Krutoy242 opened 1 year ago

Krutoy242 commented 1 year ago

Updating to 8.0 version causing crash from mod Redstone Arsenal:

LoaderExceptionModCrash: Caught exception from Redstone Arsenal (redstonearsenal)
Caused by: java.lang.VerifyError: Bad local variable type
Exception Details:
  Location:
    net/minecraftforge/common/ISpecialArmor$ArmorProperties.applyArmor(Lnet/minecraft/entity/EntityLivingBase;Lnet/minecraft/util/NonNullList;Lnet/minecraft/util/DamageSource;D)F @392: aload

Downgrading to previous version fixes issue.

debug.log

CorneliusCornbread commented 1 year ago

crash-2023-05-30_19.45.46-client.txt

Same issue, not sure what is causing my crash however.

Rongmario commented 1 year ago

Not the same issue, that's #30

Rongmario commented 1 year ago

@Krutoy242 can you try without Better Hurt Timer?

(For ref): Problem with variables not lining up here

Krutoy242 commented 1 year ago

No crash when i disabled BHT.

Krutoy242 commented 1 year ago

Installed 8.2 MixinBooter and enabled Better Hurt Timer. Still crashing on game load with same error:

LoaderExceptionModCrash: Caught exception from Redstone Arsenal (redstonearsenal)
Caused by: java.lang.VerifyError: Bad local variable type

https://mclo.gs/GVp6HJt

Rongmario commented 1 year ago

That's correct, I haven't fixed it and it ultimately is the mod's fault rather than mine.

Krutoy242 commented 1 year ago

Oh, i though patch notes Fixes some crashes from mods using unconventional methods to load mixins was about my issue 😅

CalaMariGold commented 1 year ago

Is it possible that this can be fixed on MB's side? BHT hasn't been updated for 1.12 since 2021 and there aren't really any good alternatives.

Desoroxxx commented 1 year ago

Is it possible that this can be fixed on MB's side? BHT hasn't been updated for 1.12 since 2021 and there aren't really any good alternatives.

What does Nodami does not have compared to BHT

Rongmario commented 1 year ago

@Krutoy242 is it possible for you to weigh in on this also? It seems like the author of Better Hurt Timer recommends Nodami over it if one is experiencing issues with it.

I'd hope Nodami works fine with MB 8+.

CalaMariGold commented 1 year ago

I noticed that 8.4 doesn't actually crash with BHT, but whenever a mob attacks you, that mob vanishes.

Krutoy242 commented 1 year ago

recommends Nodami

Ok, i will try to test that.

Sereath commented 11 months ago

Thats very unfortunate, Ive been slowly trying to update all my mods and some of them made 8.0+ a mandatory requirement. Which has been giving me many problems ever since.

After getting hit by a zombie: https://gist.github.com/Sereath/21cfb7ddac35922bcb6259c871498ef3

I don't think I can replace BHT right now, pain. And it is understandable, I just wanted to share.