Birthday

[cozmo]

Adding the initial thrift-pool files.

[rgarcia]

nit: I'd prefer a repo name that contained "js" or "node" somewhere. My guess is that we might write similar pooling logic for other languages

[ipam73]

@jonahkagan @templaedhel and I added some tests. Let me know what you think. f5b0cc88e133535667f6f39a12cd37220fcdfb3f

[ipam73]

Updated changes:

• Allow passing thrift options
• Add timeout listener for thrift timeout event
• Add listeners in client code to handle errors and timeouts after connection has been acquired

Testing:

• Added additional unit testing
• Integration testing -- in process of testing with real thrift library and service.

To-do:

• Revisiting README to make sure it reflects changes.

[ipam73]

@kvigen @jonahkagan

[ipam73]

After manual testing, added f8b8e7f5fbbde4b503f30c1f42799cf7b32f032b Change: add "close" listener, test case, use debug package for logging Context: when the service is down and a new connection is attempted to be established a "connect" event is emitted by the net package directly followed by a "close" event. In order to catch this as an error, the "close" event listener needs to create and return an error.

[jonahkagan]

Seems like a reasonable change to me :+1:

[kvigen]

except for the last few comments, this looks good to me