Clever / thrift-pool

A module that wraps thrift interfaces in connection pooling logic to make them more resilient.
Apache License 2.0
22 stars 15 forks source link

add coffee-script dep to package.json #3

Closed ryanbarry closed 9 years ago

ryanbarry commented 9 years ago

realized this wasn't in the package.json already when some projects using a newer version of CS gave errors on startup

v1.8+ gives:

Error: Use CoffeeScript.register() or require the coffee-script/register module to require .coffee.md files.

v1.7.x gives:

/Users/rbarry/thrift-pool/lib/index.coffee:1
ion (exports, require, module, __filename, __dirname) { _ = require "underscor
                                                                    ^^^^^^^^^^^^
SyntaxError: Unexpected string
ipam73 commented 9 years ago

@ryanbarry Thanks so much for this fix! Sorry that this slipped through our review, tests are failing and I have one small comment, but that should be easy to fix.

ryanbarry commented 9 years ago

understandable, i didn't even notice it at first either, since we're using coffeescript as well.

i had to change the require to get newer versions of coffeescript to work, but looks good now :smile:

ipam73 commented 9 years ago

Thanks, this looks great!