Clever / thrift-pool

A module that wraps thrift interfaces in connection pooling logic to make them more resilient.
Apache License 2.0
22 stars 15 forks source link

notify CI failure #31

Closed tnsardesai closed 2 months ago

tnsardesai commented 2 months ago

Jira

https://clever.atlassian.net/browse/INFRANG-6435

Overview

PR created via Microplane

This PR enables/fixes slack notifications via Dapple bot when CI fails on master, sent to the commit author, to ensure that eng action can be taken to ensure master doesn't remain in a failed state. This prevents issues such as a subsequent deploy deploying more new code than intended because it picks up a previous failed build's code.

If you have questions, please ask here or in #oncall-infra.

Feel free to merge this PR upon reviewing or simply ignore. If it is ignored, it will be merged by infra eventually

Testing

This github action has been tested in our do-nothing repo and test details can be found in https://github.com/Clever/ci-scripts/pull/140